Jean-Daniel Cryans has posted comments on this change.

Change subject: [java-client] disconnect all tablets in 
TestAsyncKuduSession.disconnectAndWait
......................................................................


Patch Set 1:

(1 comment)

Nice catch.

http://gerrit.cloudera.org:8080/#/c/3329/1/java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java
File java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java:

Line 93:     for (TabletClient tabletClient : client.getTabletClients()) {
Instead, check that the port you get isn't the master's. BaseKuduTest offers 
findLeaderMasterPort(). You don't need to disconnect the master here. If you'd 
rather keep this code than change it the method's name and all the comments 
above such as "4. Disconnect the TS."


-- 
To view, visit http://gerrit.cloudera.org:8080/3329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00b2530c63d70b37cc7143de9f6190f0fbf349de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to