Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: [java-client] disconnect all tablets in 
TestAsyncKuduSession.disconnectAndWait
......................................................................


[java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait

The testDisconnect test creates a single tablet table, scans the table,
disconnects a random tablet client, and then waits until the client has no
tablet clients. Since the Java client considers the master a tablet, this lasts
until the remaining tablet client times out. This commit changes the test to
instead disconnect all tablet clients, which shaves about 10 seconds off the
runtime.  There are also a few drive-by fixups, including renaming
AsyncKuduClient.getTableClients to getTabletClients.

The test fix exposed an existing race condition in the TabletClient
disconnect/reconnect handling which would cause an RPC to be 'lost' and never
be sent (eventually causing a timeout).

Change-Id: I00b2530c63d70b37cc7143de9f6190f0fbf349de
Reviewed-on: http://gerrit.cloudera.org:8080/3329
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans
---
M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
M java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/kududb/client/ITClient.java
M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java
6 files changed, 17 insertions(+), 25 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I00b2530c63d70b37cc7143de9f6190f0fbf349de
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins

Reply via email to