Dan Burkert has posted comments on this change.

Change subject: Update documentation and build helper script
......................................................................


Patch Set 1:

(1 comment)

In order to pass validation, this patch will need to be rebased over the latest 
changes in the master branch.  We unfortunately had a breaking change to the 
testing infrastructure, and the fix only went in yesterday.

http://gerrit.cloudera.org:8080/#/c/3336/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:

Line 28:    [[ "$(cat /etc/redhat-release)" =~ 
(CentOS|RedHatEnterpriseServer)([[:space:]]|[[:alnum:]])*[[:space:]]+6\.[[:digit:]]+
 ]]; then
This will fail on non-RHEL derived distros (notice the `set -e` above).  Is it 
possible to instead add the provider of `lsb_release` as an RPM dependency?


-- 
To view, visit http://gerrit.cloudera.org:8080/3336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Cenk Uyan <cenku...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to