Mike Percy has posted comments on this change.

Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
......................................................................


Patch Set 6:

(1 comment)

I wish there was an easier way to hide the data object so that we can only 
access it through the lock object. It's too easy to make the mistake what this 
patch is fixing when using COWLocks.

http://gerrit.cloudera.org:8080/#/c/3309/6/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:

Line 525:   // Send the "create tablet request" to a particular peer.
Comment needs updating -- it's for all peers of a particular tablet


-- 
To view, visit http://gerrit.cloudera.org:8080/3309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e24f6035f4d778995ea3f295396f5fbd760d6c6
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to