David Ribeiro Alves has posted comments on this change.

Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................


Patch Set 2:

(1 comment)

can you add a test for this? something simple like setting the election timeout 
really high and then making sure we get a leader immediately?

http://gerrit.cloudera.org:8080/#/c/3344/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

Line 312:   bool only_voter = false;
pull this out to a method. something like IsSingleNodeConfig() or 
IsSingleVoterConfig


-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to