Mike Percy has posted comments on this change.

Change subject: Remove the LocalConsensus implementation
......................................................................


Patch Set 3:

> general wondering. Should we just kill the consensus.h interface
 > and refactor RaftConsensus->Consensus or use RaftConsensus
 > directly? Seems unlikely that we'll ever want another consensus
 > impl, so one less indirection layer and less virtual methods. Any
 > roadblocks on the way to do this?

Well, if we do that let's do it in a different CR. I don't think we'll ever 
have another Consensus impl but still probably something worth discussing on 
the list

-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: No

Reply via email to