Alexey Serbin has posted comments on this change.

Change subject: Do not run (g)addr2line translator on MacOS X
......................................................................


Patch Set 2:

> Thanks for making those changes. Looks good to me, though
 > ultimately I'll defer to someone who actually uses Mac OS.
 > 
 > If you do have some time, I'd love to know whether translation
 > works in sanitizer builds on Mac OS. No worries if you've got other
 > thing to look at, though.

Yep, sure -- I would like to get some feedback from Dan Burkert.  Yes, I'll try 
those sanitizer builds: I'm also curious how that works for those builds.

-- 
To view, visit http://gerrit.cloudera.org:8080/3360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: No

Reply via email to