Dan Burkert has posted comments on this change. Change subject: Improvements and corrections to Impala CREATE TABLE examples ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3376/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: Line 501: DISTRIBUTE BY HASH (id) INTO 4 BUCKETS > The "(id)" isn't needed here, all key columns is the default. Maybe remove Does Impala allow this? We have been moving away from any kind of implicit partitioning configuration. I suggest we don't allow this at all, the programatic APIs don't, so it would just introduce a discrepancy. I also think it's not very clear without a proper PRIMARY KEY clause. -- To view, visit http://gerrit.cloudera.org:8080/3376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I093972a7b806787a8c72634851796eebb5e1ae4c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Casey Ching <ca...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org> Gerrit-HasComments: Yes