Adar Dembo has posted comments on this change.

Change subject: Update Java client for new master GetTableLocations semantics
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3303/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1135:                 // The table is most likely still being create.
Nit: 'created' was correct.


Line 1136:                 LOG.debug("Table {} has a non-running tablet", 
tableId);
Does this automatically include backoff?


Line 1137:                 return loopLocateTable(tableId, startPartitionKey, 
endPartitionKey,
Is there an upper bound on the recursive depth here? I suppose we already had 
that problem before (L1164-1165) but I'm curious to know whether either of 
these are safe.


http://gerrit.cloudera.org:8080/#/c/3303/2/java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java
File java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java:

Line 249:     assertTrue("unreachable", false);
> use fail()
Better yet, put it inside the try {} itself after  syncLocateTable(). Then you 
don't need to return from the catch.


-- 
To view, visit http://gerrit.cloudera.org:8080/3303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80bf5661aed1ba435800211411b3273874e5bbcf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to