Dan Burkert has posted comments on this change.

Change subject: Update Java client for new master GetTableLocations semantics
......................................................................


Patch Set 2:

(1 comment)

The changes I made today have been made significantly simpler by building on 
top of https://gerrit.cloudera.org/#/c/3386/.  I don't think any of the review 
comments still apply.  There still isn't a lot of explicit testing of this 
change, except that these codepaths are hit in pretty much every operation 
involving a tablet.

http://gerrit.cloudera.org:8080/#/c/3303/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1134:               if (response.getError().getCode() == 
Master.MasterErrorPB.Code.TABLET_NOT_RUNNING) {
> IIUC you're relying on existing tests to pass to verify this new check?
No, the new tests will hit this codepath in the case where the tablets are not 
yet created when we start calling syncLocateTable.  The behavior should here is 
just a retry, so no special logic is needed in the tests themselves.


-- 
To view, visit http://gerrit.cloudera.org:8080/3303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80bf5661aed1ba435800211411b3273874e5bbcf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to