Adar Dembo has posted comments on this change.

Change subject: [java-client] use tablet cache for locateTablet calls
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3386/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1876:     private final List<LocatedTablet.Replica> replicas = new 
ArrayList<>();
> I don't think the tradeoff is worth it. Maybe we should document this, but 
Makes sense to a degree, though bear in mind we're already doing DNS resolution 
with the lock held, and the overhead of a COW list copy is peanuts by 
comparison.

If we began doing the resolution outside the lock, then yeah, the hit would be 
more sizable.


-- 
To view, visit http://gerrit.cloudera.org:8080/3386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to