Dan Burkert has posted comments on this change.

Change subject: [java-client] use tablet cache for locateTablet calls
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3386/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1876:     private final List<LocatedTablet.Replica> replicas = new 
ArrayList<>();
> Makes sense to a degree, though bear in mind we're already doing DNS resolu
COWAL was my first thought here, but from a look through the API I couldn't 
figure out a way to atomically swap the entire contents of the list.  Now that 
I think about it, though, what we want is a AtomicReference<ImmutableList>.  
I'll make the change.


http://gerrit.cloudera.org:8080/#/c/3386/2/java/kudu-client/src/main/java/org/kududb/client/KuduTable.java
File java/kudu-client/src/main/java/org/kududb/client/KuduTable.java:

Line 143:    * Use the {@link KuduScanToken} API instead of this method if 
possible.
> Why would it not be possible to use the scan token API? Why haven't we depr
I would like to explicitly deprecate these methods.  I initially didn't want to 
wrap that into this bigger change, but I'll go ahead.


-- 
To view, visit http://gerrit.cloudera.org:8080/3386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to