Dan Burkert has posted comments on this change.

Change subject: [java-client] use tablet cache for locateTablet calls
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3386/2//COMMIT_MSG
Commit Message:

PS2, Line 9: This simplifies and improves the performance of 
AsyncKuduClient::locateTable by
           : using the client's existing tablet cache.
> Nit: there's not enough context in this patch to know why you're making thi
Done


http://gerrit.cloudera.org:8080/#/c/3386/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1230:   private final class MasterLookupCB implements Callback<Object, 
Master.GetTableLocationsResponsePB> {
> Nit: too long now? Unclear.
Done


Line 2047:     List<LocatedTablet.Replica> getReplicas() {
> Quickly looking through the code, looks like we don't do it, and I'm not su
Immutability should be the default IMO.


-- 
To view, visit http://gerrit.cloudera.org:8080/3386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to