Mike Percy has posted comments on this change.

Change subject: Remove the LocalConsensus implementation
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3350/5/src/kudu/consensus/metadata.proto
File src/kudu/consensus/metadata.proto:

Line 89:   // Obsolete. This parameter has been retired.
> why are we keeping this around?
We need to provide some way to specify that field #2 should not be reused. 
Since our version of protobuf apparently doesn't support the "reserved" 
keyword, and comments aren't enforced by the compiler, this seems to be the 
best option.


http://gerrit.cloudera.org:8080/#/c/3350/5/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:

Line 255:     CHECK_EQ(server_->instance_pb().permanent_uuid(), 
config.peers(0).permanent_uuid());
> can we change this to make it generic, i.e. make sure that our uuid is amon
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to