Mike Percy has posted comments on this change. Change subject: Use RaftConsensus instead of LocalConsensus in tests ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3346/4/src/kudu/consensus/consensus.h File src/kudu/consensus/consensus.h: Line 35: > remove extra line Done PS4, Line 136: WaitUntilLeader > rename this? append ForTests Done http://gerrit.cloudera.org:8080/#/c/3346/4/src/kudu/tserver/ts_tablet_manager-test.cc File src/kudu/tserver/ts_tablet_manager-test.cc: Line 89: RETURN_NOT_OK(tablet_peer->consensus()->WaitUntilLeader(MonoDelta::FromSeconds(10))); > can just return here Done -- To view, visit http://gerrit.cloudera.org:8080/3346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes