Mike Percy has posted comments on this change.

Change subject: Add Raft remote bootstrap design doc
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3395/2/docs/design-docs/raft-remote-bootstrap.md
File docs/design-docs/raft-remote-bootstrap.md:

PS2, Line 108:  `DOES_NOT_EXIST` or is
             : `DELETED`
> This highlighting looks good for states in the state machine. Could you add
Done


Line 187: 2. mkdir quarantine directory (QDIR).
> Nit: none of the other UNIX-y operations in this list are referenced by the
Done


Line 257: 1. Master sends an AddServer() RPC to the leader of the tablet to add 
a new
> Nit: a singleton list is just noise, could you remove the "1." prefix?
Done


PS2, Line 260:    a. This AddServer() RPC will specify the prior committed raft 
config for the
             :       tablet to ensure that the request is idempotent.
> Unfortunately, GH markdown requires that sublists be numeric too. Otherwise
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to