Adar Dembo has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 1: Code-Review+2

Change looks fine, but the comment you wrote in tsan-suppressions.txt seemed to 
suggest (fairly confidently) that the non-acquire based loads were safe, due to 
the x86 TSO. Has your thinking on that changed since then?

Also, is there an effect on performance?

-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

Reply via email to