Adar Dembo has posted comments on this change.

Change subject: Make 'num_attempts' in RequestIdPB required
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3408/2//COMMIT_MSG
Commit Message:

Line 15: requires distinguising different attempts. Using 'num_attempts' is
Nit: "requires distinguishing between different attempts"


http://gerrit.cloudera.org:8080/#/c/3408/2/src/kudu/rpc/rpc_header.proto
File src/kudu/rpc/rpc_header.proto:

Line 127:   // Set at 1 in the first attempt.
Nit: "Set to 1..."


-- 
To view, visit http://gerrit.cloudera.org:8080/3408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd8f780826438278993554546edfae90bf1a39df
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to