Todd Lipcon has posted comments on this change.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


Patch Set 1:

(1 comment)

The non-acquire loads are safe _assuming that the compiler doesn't re-order 
anything_. It seems unlikely that the compiler would reorder in this case, 
but... I wouldn't bet my life on it. Note that acquire_load on x86 is just a 
normal load with a 'compiler barrier', not any different assembly instruction.

http://gerrit.cloudera.org:8080/#/c/3410/1/src/kudu/tablet/memrowset.h
File src/kudu/tablet/memrowset.h:

Line 79:   Mutation* acquire_redo_head() {
> docs
not clear enough given it's a one-line implementation?


-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to