Todd Lipcon has posted comments on this change. Change subject: consensus: Crash if we fail to append to the WAL ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3406/1/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: Line 435: MAYBE_RETURN_FAILURE(FLAGS_log_inject_io_error_on_append_fraction, this is only injecting errors at the call site of the AsyncAppend, not actually where it's getting appended to disk. I think that's an unrealistic place to inject the IOError -- better to do it nearer the actual write in WritableLogSegment I think, or at least on the AppendThread, to make sure it propagates back properly -- To view, visit http://gerrit.cloudera.org:8080/3406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5ffa6d60f46ce4d6c3da4c6e7878ab07d99c65 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
