Mike Percy has posted comments on this change.

Change subject: consensus: Crash if we fail to append to the WAL
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3406/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

Line 1928:   CHECK_OK(log_->AsyncAppendCommit(std::move(commit_msg), 
Bind(&DoNothingStatusCB)));
> I understand the LOG(FATAL) in the other location, but why the CHECK_OK() h
ah, you're right. I need a fatal callback here.


-- 
To view, visit http://gerrit.cloudera.org:8080/3406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5ffa6d60f46ce4d6c3da4c6e7878ab07d99c65
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to