Adar Dembo has posted comments on this change.

Change subject: Allow crcutil* symbols in the client
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3412/4/src/kudu/client/symbols.map
File src/kudu/client/symbols.map:

Line 32:       # From src/kudu/util/crc.{h,cc}.
That's not quite right, though; these symbols are defined by crcutil in 
thirdparty. So I would just say:

  # crcutil
  crcutil::*;
  crcutil_interface::*;

That should be good enough to indicate a thirdparty dependency.


-- 
To view, visit http://gerrit.cloudera.org:8080/3412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87fa1b69390a566ab141cf4cf9be84608be73390
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to