Mike Percy has posted comments on this change.

Change subject: log: Mark allocation finished even if allocation had an error
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3234/1/src/kudu/consensus/log.cc
File src/kudu/consensus/log.cc:

Line 848
> I think you missed this comment.
Yep, missed it. Done.


http://gerrit.cloudera.org:8080/#/c/3234/3/src/kudu/consensus/log.h
File src/kudu/consensus/log.h:

Line 406: // ReplicateMsg elements are owned and must be freed by the caller.
> Where are the ReplicateMsg elements? I only see ReplicateRefPtr elements an
Yes... ownership in this thing is not very intuitive. I don't really like it. I 
will try to do a better job of explaining it in the comments.


-- 
To view, visit http://gerrit.cloudera.org:8080/3234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22bf946a42d0ec32c35164acd9e6e6cef18dcc3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to