Todd Lipcon has submitted this change and it was merged.

Change subject: tablet: fix sloppiness around atomic mutation lists
......................................................................


tablet: fix sloppiness around atomic mutation lists

Previously we had some TSAN suppressions around our handling of
the Mutation linked lists. This removes them and does the appropriate
Acquire_Loads that we were missing.

In practice I don't think we were hitting any bugs due to this, but
it's hard to know -- maybe this was a cause of some recent crashes?
Either way, fewer suppressions is better.

Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Reviewed-on: http://gerrit.cloudera.org:8080/3410
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <a...@cloudera.com>
---
M build-support/tsan-suppressions.txt
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/mutation.cc
M src/kudu/tablet/mutation.h
6 files changed, 25 insertions(+), 15 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf4e404abd2729660a38841759d3894c4af5eb20
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to