Adar Dembo has posted comments on this change.

Change subject: Add Env::GetBytesFree() method
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3451/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

Line 930:       *bytes_free = buf.f_frsize * buf.f_ffree;
f_ffree is wrong; that's the number of free inodes. I think you meant f_bfree.

Also, would be more concise (and hopefully not more confusing) as a ternary.


-- 
To view, visit http://gerrit.cloudera.org:8080/3451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica484be987312b275bafdd6e6fa79239ed3ac1ff
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to