Todd Lipcon has posted comments on this change.

Change subject: Integrate the request tracker with the client
......................................................................


Patch Set 8:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/3080/8//COMMIT_MSG
Commit Message:

Line 15: any specific tests.
it's not possible to use RetriableRpc within rpc_stub-test to test the client 
part?


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:

Line 194:            const scoped_refptr<RequestTracker>& request_tracker,
what about storing this in the Batcher? or grabbing it via 
batcher->client->data->request_tracker as necessary? seems like an unnecessary 
extra parameter (and refcount incr/decr)


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:

Line 72: using rpc::RequestTracker;
spurious changes in this file?


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:

Line 27: #include "kudu/rpc/request_tracker.h"
can be a forward decl, no?


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:

Line 34: #include "kudu/rpc/request_tracker.h"
spurious?


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/rpc/retriable_rpc.h
File src/kudu/rpc/retriable_rpc.h:

Line 125:     // in flight, so we retry with a delay.
I think this merits a warning.


Line 193:     request_id->set_first_incomplete_seq_no(internal::NO_SEQ_NO);
why not just leave it unset in the PB?


Line 210:   request_tracker_->RpcCompleted(sequence_number_);
nit: mid-comment


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/rpc/rpc_controller.cc
File src/kudu/rpc/rpc_controller.cc:

Line 103:   return *request_id_.get();
nit: I think you dont need .get()


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/rpc/rpc_controller.h
File src/kudu/rpc/rpc_controller.h:

Line 114:   const RequestIdPB& request_id() const;
I think this is somewhat error prone - IIRC the RPC layer "steals" the request 
ID out of the RpcController at send time, no? Seems like it's worth a doc 
comment that these are not accessible after an RPC has been sent. And maybe a 
DCHECK like some of the other accessors have?


-- 
To view, visit http://gerrit.cloudera.org:8080/3080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to