Mike Percy has posted comments on this change.

Change subject: Allow for reserving disk space for non-Kudu processes
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3135/8/src/kudu/fs/block_manager-test.cc
File src/kudu/fs/block_manager-test.cc:

PS8, Line 968: 
             : #endif // defined(__linux__)
> Do we still need this sleep now that we're using a FINE clock?
No. I thought I removed it... thanks for the catch.


http://gerrit.cloudera.org:8080/#/c/3135/5/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

Line 1292:                                                      
FLAGS_log_container_preallocate_bytes,
> I see your point (regarding soft vs. hard limits). So let's proceed with wh
Done


http://gerrit.cloudera.org:8080/#/c/3135/8/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

PS8, Line 1234: 
              :       InsertOrDie(&full_root_indexes
> Nit: it's not using indexes anymore.
Done


Line 1240:   // In case one or more root paths have hit their reserved space 
limit, we
> Why not InsertOrDie() here and below? I don't think root_paths_ can have du
You're right, it's safe to do now, after my last refactor.


PS8, Line 1302: 
              :       }
              :       RETURN_NOT_OK(s); // Catch IOErrors, etc.
              :       RETURN_NOT_OK(container->Preallocate(FLAGS_lo
> Nit: I think getting the gist of the entire line would be easier if you use
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd0451d4dbddc1783019a53302de0263080939c7
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to