Mike Percy has posted comments on this change.

Change subject: catalog_manager: prevent spurious dirty callbacks from crashing 
the process
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3465/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

Line 600:     std::lock_guard<simple_spinlock> l(state_lock_);
Could you add a DCHECK here that the worker pool has a maximum of 1 threads? If 
that's hard, how about a comment where the worker_pool_ is constructed that 
specifies that we rely on that for correctness here.


http://gerrit.cloudera.org:8080/#/c/3465/2/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:

Line 586: static void GetTableLocations(const char* kTableName,
Rename to LoopGetTableLocations?


-- 
To view, visit http://gerrit.cloudera.org:8080/3465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bc602a51a4914ec13f926bfca555c816a2ee509
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to