Todd Lipcon has posted comments on this change.

Change subject: Make ParseAddressList not OK empty address lists
......................................................................


Patch Set 1:

(2 comments)

please add a test as well

http://gerrit.cloudera.org:8080/#/c/3486/1/src/kudu/tools/kudu-ksck.cc
File src/kudu/tools/kudu-ksck.cc:

Line 83:   // return early if there were no addresses to parse
this could also happen if resolution failed, etc, right? not just the case of 
no addresses


http://gerrit.cloudera.org:8080/#/c/3486/1/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:

Line 172:   
nit: trailing whitespace


-- 
To view, visit http://gerrit.cloudera.org:8080/3486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idedc2ad9f2ab321a5bb7aa65ea59b8f1a4186377
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to