Dan Burkert has posted comments on this change.

Change subject: [java-client] refactor AsyncKuduSession
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/3477/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

PS1, Line 1400: locateTablet
> How does this related to the other locateTablet() method? It seems to be do
Done


http://gerrit.cloudera.org:8080/#/c/3477/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java:

PS1, Line 396: Must not be concurrently accessed
> It already is it seems though, the client can call it with a flusher task f
The flusher task and the client task both lock the monitor and set the active 
buffer to null before calling this, so I don't think it's possible.


Line 705:     private List<BufferedOperation> operations = new ArrayList<>();
> final
Done


PS1, Line 725: (
> not closing the parenthesis in the comment
Done


http://gerrit.cloudera.org:8080/#/c/3477/1/java/kudu-client/src/main/java/org/kududb/client/RowError.java
File java/kudu-client/src/main/java/org/kududb/client/RowError.java:

Line 87:         ", tablet=" + (operation.getTablet() == null ? null :
> Just put getTablet there directly, RemoteTablet has toString.
Done


http://gerrit.cloudera.org:8080/#/c/3477/1/java/kudu-client/src/main/java/org/kududb/util/AsyncUtil.java
File java/kudu-client/src/main/java/org/kududb/util/AsyncUtil.java:

Line 54:    * Workaround for {@link Deferred#addBoth}'s failure to use generics 
correctly.
> Can you be more clear regarding what this does and why someone should use i
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee6d029b1a56e254bfb9a870917883abeadb6b8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to