Adar Dembo has posted comments on this change.

Change subject: replace boost::detail::yield with std::this_thread::yield
......................................................................


Patch Set 1:

> I dont think this is a good idea - we use boost yield in some cases
 > where we might spin a pretty long time and spinning on
 > sched_yield() would suck up lots of kernel CPU (it reschedules the
 > same thread if there's nothing else to run)

It doesn't seem like it'd be too much work to implement our own adaptive yield. 
The boost implementation is small.

-- 
To view, visit http://gerrit.cloudera.org:8080/3492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c94f8377982028e608c0b0d0b56a48f8df4dfe2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to