David Ribeiro Alves has posted comments on this change.

Change subject: Integrate the request tracker with the client
......................................................................


Patch Set 8:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/3080/8//COMMIT_MSG
Commit Message:

Line 15: any specific tests.
> I guess I can come up with a unit test for retriable rpc, if that helps, bu
as we discussed in person, the new plan is to test retriable rpc when the 
result tracker is in, on rpc-stress-test. punting on this until then


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:

Line 194:            const scoped_refptr<RequestTracker>& request_tracker,
> what about storing this in the Batcher? or grabbing it via batcher->client-
turns out this can't be stored in the batcher (I tried and got sigsevs), rpcs 
may outlive the batcher


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/client/client-internal.cc
File src/kudu/client/client-internal.cc:

Line 72: using rpc::RequestTracker;
> spurious changes in this file?
Done


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:

Line 27: #include "kudu/rpc/request_tracker.h"
> can be a forward decl, no?
Done


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:

Line 34: #include "kudu/rpc/request_tracker.h"
> spurious?
Done


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/rpc/retriable_rpc.h
File src/kudu/rpc/retriable_rpc.h:

Line 125:     // in flight, so we retry with a delay.
> I think this merits a warning.
this doesn't return a non-ok status currently (we removed the max in flights 
thing) so I just made this a check


Line 193:     request_id->set_first_incomplete_seq_no(internal::NO_SEQ_NO);
> why not just leave it unset in the PB?
removed this branching since First incomplete now just returns a NO_SEQ_NO.


Line 210:   request_tracker_->RpcCompleted(sequence_number_);
> nit: mid-comment
Done


Line 210:   request_tracker_->RpcCompleted(sequence_number_);
> as a safety check, I think we should probably set the seq number back to NO
Done


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/rpc/rpc_controller.cc
File src/kudu/rpc/rpc_controller.cc:

Line 103:   return *request_id_.get();
> nit: I think you dont need .get()
Done


http://gerrit.cloudera.org:8080/#/c/3080/8/src/kudu/rpc/rpc_controller.h
File src/kudu/rpc/rpc_controller.h:

Line 114:   const RequestIdPB& request_id() const;
> I think this is somewhat error prone - IIRC the RPC layer "steals" the requ
there's a DCHECK there, is that not what you meant? added the comment you 
suggested


-- 
To view, visit http://gerrit.cloudera.org:8080/3080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to