Dan Burkert has posted comments on this change.

Change subject: thirdparty: add boost and switch to header-only build
......................................................................


Patch Set 1:

(5 comments)

I'm +1 on moving boost into thirdparty.  I like that it removes complexity from 
the build.

http://gerrit.cloudera.org:8080/#/c/3500/1//COMMIT_MSG
Commit Message:

Line 18:    libstdc++, and libsasl, all of which should not be managed due to 
their
and openssl, although the point still stands.


PS1, Line 22: Some distros (e.g. SLES12) don't offer
            :    system packages
The specific issue with SLES 12 (and I would assume the majority of the small 
number of distros with this issue) is that it's missing boost-static, not the 
boost headers, so I think just moving to headers fixes it.


http://gerrit.cloudera.org:8080/#/c/3500/1/docs/contributing.adoc
File docs/contributing.adoc:

Line 151: We are in the process of removing all remaining `boost` dependencies 
from the
We still have 'approved' boost libraries.  I would vote to keep the approved 
list, but update it to just include 'optional' and 'intrusive'.


http://gerrit.cloudera.org:8080/#/c/3500/1/thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch
File thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch:

Line 1: --- boost/optional/optional_fwd.hpp     2016-05-05 14:13:30.000000000 
-0700
ah I didn't see this before I wrote the version comment.  If you want to carry 
the patch instead of reverting to an older version that's fine with me.


http://gerrit.cloudera.org:8080/#/c/3500/1/thirdparty/vars.sh
File thirdparty/vars.sh:

Line 145: BOOST_VERSION=1_61_0
1.61 has the regression with optional_fwd.hpp, right?  If so, I think we should 
use a slightly older version instead (1.59 is well tested I think).  I'm 
usually pretty bullish on pushing the latest version of dependencies, but I 
don't see a real upside in this case.


-- 
To view, visit http://gerrit.cloudera.org:8080/3500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b73a8e2a86099429b6032023a01a0da7b02371
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to