Adar Dembo has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3500/1//COMMIT_MSG Commit Message: Line 18: libstdc++, and libsasl, all of which should not be managed due to their > and openssl, although the point still stands. Right, though I explicitly omitted openssl because, at least for now, you really can't configure Kudu to use it. PS1, Line 22: Some distros (e.g. SLES12) don't offer : system packages > The specific issue with SLES 12 (and I would assume the majority of the sma Ah, I misread the blurb in installation.adoc. Will update. http://gerrit.cloudera.org:8080/#/c/3500/1/docs/contributing.adoc File docs/contributing.adoc: Line 151: We are in the process of removing all remaining `boost` dependencies from the > We still have 'approved' boost libraries. I would vote to keep the approve I really was hoping to avoid introducing new Boost usage, so that we stand a chance of removing the whole thing some day. Is your point that adding a new usage of e.g. boost::optional isn't a big deal because, if/when we do replace it, updating an additional call-site is no big deal? -- To view, visit http://gerrit.cloudera.org:8080/3500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b73a8e2a86099429b6032023a01a0da7b02371 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
