Adar Dembo has posted comments on this change.

Change subject: Update docs on how to run gcovr
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3508/1/README.adoc
File README.adoc:

Line 241: $ mkdir cov_html
Hmm, probably don't need this anymore.


Line 244:       --gcov-executable=$(pwd)/../../build-support/llvm-gcov-wrapper \
Why do we need $(pwd)? We're in build/coverage; given the "blessed" build 
layout, isn't that guaranteed to be two subdirs deeper than build-support?


Line 245:       --html --html-details -o coverage.html
What happens if you run without -o?


-- 
To view, visit http://gerrit.cloudera.org:8080/3508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I494136e20452b76572d753b54fc7a095aa54a69b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to