Dan Burkert has posted comments on this change.

Change subject: thirdparty: add boost and switch to header-only build
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3500/1/docs/contributing.adoc
File docs/contributing.adoc:

Line 151: We are in the process of removing all remaining `boost` dependencies 
from the
> I really was hoping to avoid introducing new Boost usage, so that we stand 
Yes, but additionally I think boost::optional is a powerful tool for writing 
higher quality code, and its use should be encouraged wherever it makes sense 
from a code simplicity/maintainability perspective.  Optional is especially 
important when working with value types, as is often possible with the new move 
semantics, and unlocks simpler and more performant solutions than the existing 
tools (e.g. nullable unique_ptr) in many cases.  Basically, I think Optional is 
a great abstraction and to discourage its use because of a minor distaste of 
boost is going to do more harm than good.

I don't care as much about intrusive, and would agree that we should not 
encourage it, only that it should be available in the very few cases where it 
is justified.  I doubt it will get used again any time soon, so it's a bit of a 
non-issue.


-- 
To view, visit http://gerrit.cloudera.org:8080/3500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b73a8e2a86099429b6032023a01a0da7b02371
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to