Todd Lipcon has posted comments on this change.

Change subject: Allow to force-override color diagnostics
......................................................................


Patch Set 1:

I use something like this locally -- when I run 'ninja', it sometimes re-runs 
cmake for me, but the output is a pipe into ninja, rather than a TTY, which 
means that cmake will decide not to use color.

My workaround is to put it in my ccache-clang wrapper though:

#!/bin/bash -e

if [ -n "$CLANG_ALWAYS_COLOR" ] || test -t 2 ; then
  color_flags="-fcolor-diagnostics"
fi

CCACHE_CPP2=yes exec ccache clang++ -Qunused-arguments $color_flags "$@"

-- 
To view, visit http://gerrit.cloudera.org:8080/3509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c19651df6d74753b0d4e8ac85ff98326dee7b10
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to