Mike Percy has posted comments on this change. Change subject: Migrate from boost::optional to kudu::optional ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3513/1/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: Line 411: exclusive_upper_bound_ = spec->exclusive_upper_bound_key()->encoded_key(); Need to check w/ Todd on this but I think it should be fine to do it. http://gerrit.cloudera.org:8080/#/c/3513/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 670: return; } Oops, inadvertent change, need to restore the newline before this brace. http://gerrit.cloudera.org:8080/#/c/3513/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 993: Status delete_status = DeleteTabletData(meta, TABLET_DATA_TOMBSTONED, optional<OpId>()); This should probably be replaced with nullopt -- To view, visit http://gerrit.cloudera.org:8080/3513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46ba817d507af8b26add764dc3859364d15e0da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
