Adar Dembo has posted comments on this change.

Change subject: Implement kudu::optional replacement for boost::optional
......................................................................


Patch Set 1:

(3 comments)

I only skimmed this; I think a real review requires a level of C++ knowledge 
that I don't think I have.

http://gerrit.cloudera.org:8080/#/c/3512/1/src/kudu/gutil/dynamic_annotations.h
File src/kudu/gutil/dynamic_annotations.h:

Line 64: #include <string.h> // For size_t.
Technically size_t is defined in stddef.h (or cstddef, if you prefer a C++ 
header).


http://gerrit.cloudera.org:8080/#/c/3512/1/src/kudu/util/CMakeLists.txt
File src/kudu/util/CMakeLists.txt:

Line 297: ADD_KUDU_TEST(optional-test)
Nit: precedes os-util-test alphabetically.


http://gerrit.cloudera.org:8080/#/c/3512/1/src/kudu/util/optional.h
File src/kudu/util/optional.h:

Line 237:   const T& GetValueAsConstRef() const& { return 
*GetValueAsConstPtr(); }
So there's a difference between a "const" method and a "const&" method? Didn't 
know that. What is the difference?


-- 
To view, visit http://gerrit.cloudera.org:8080/3512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib80c35cc9a4712572f85eeb7717e17869cd5e081
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to