Adar Dembo has posted comments on this change.

Change subject: thirdparty: add boost and switch to header-only build
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3500/1/docs/contributing.adoc
File docs/contributing.adoc:

Line 151: We are in the process of removing all remaining `boost` dependencies 
from the
> Yes, but additionally I think boost::optional is a powerful tool for writin
Alright, then I'll update this to say something to the effect of:
1. We're actively trying to remove boost.
2. We're using boost in a header-only capacity right now; don't introduce any 
library dependencies.
3. Please don't introduce dependencies on new boost header-only features.
4. You can use existing boost header-only features on which we already depend 
(e.g. boost::optional, boost::bind). These features may be removed in the 
future; when using boost, please be mindful of the "current state" of the world 
(e.g. boost::bind might be gone soon).


-- 
To view, visit http://gerrit.cloudera.org:8080/3500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b73a8e2a86099429b6032023a01a0da7b02371
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to