Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled ......................................................................
Patch Set 1: (1 comment) > Oops. > > Outside of multi-master, this only manifests when the sole master > is booting up, right? That would explain why it happens often in > our unit tests. Yup, I just didn't want to write tests that we already have. http://gerrit.cloudera.org:8080/#/c/3516/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 814: return d; > is it important that the getDeferred call happen before delayedSendRpcToTab If by some chance the RPC completed before the return is done, we'd be sending back a new Deferred. Almost impossible to run into, but hey... -- To view, visit http://gerrit.cloudera.org:8080/3516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie33410bdcfcc1bf9d3afb559a01f50538d7e10b5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Binglin Chang <decst...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
