Alexey Serbin has posted comments on this change.

Change subject: locks: add new read-write mutex
......................................................................


Patch Set 2:

(1 comment)

LGTM with some concern regarding error detection if something goes wrong.

So, we are about to catch some those non-run-time issues like trying to acquire 
the lock held by the same thread, etc. in debug mode, which is OK.

Do we expect to catch some run-time issues like lack of shared memory to 
accommodate a new lock, etc.?  I.e. we are not propagating errors from 
pthread_rwlock_xxx() functions in release mode at all (if I'm not missing 
something).   Does it make sense to throw some sort of exception for run-time 
errors (like std::runtime_error)?

http://gerrit.cloudera.org:8080/#/c/3496/4/src/kudu/util/mutex.cc
File src/kudu/util/mutex.cc:

Line 92:   }
As Dan already mentioned: is it possible to keep the semicolon under the ifndef 
and in the same line as last statement?


-- 
To view, visit http://gerrit.cloudera.org:8080/3496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to