Adar Dembo has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 5: Verified+1

There was a build failure in the RELEASE build:
  
  01:36:24 Linking CXX shared library ../../../lib/libkrpc.so
  01:36:25 CMakeFiles/krpc.dir/constants.cc.o: file not recognized: File 
truncated
  01:36:25 collect2: error: ld returned 1 exit status
  01:36:25 make[2]: *** [lib/libkrpc.so] Error 1
  01:36:25 make[1]: *** [src/kudu/rpc/CMakeFiles/krpc.dir/all] Error 2
  01:36:25 make[1]: *** Waiting for unfinished jobs....

That file isn't touched by this patch, all of the other builds passed, and 
subsequent RELEASE builds (building off of this patch) have also passed, so I'm 
overriding Jenkins.

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to