Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3521

to review the following change.

Change subject: master_failover-itest: eliminate some flakiness
......................................................................

master_failover-itest: eliminate some flakiness

Due to the inherent asynchronicity of SIGSTOP and the lack of "exactly once"
semantics [1], it's possible for any DDL operation issued by these tests to
return a result suggesting it had already been performed prior to being
issued. See TestCreateTableSync for a detailed example.

I've never run into this myself, but it has occurred at least once [2] in
the wild.

1. Beyond basic EO semantics, RPC results would need to be persisted and
   replicated, neither of which are in scope for David's current project.
2. 
http://dist-test.cloudera.org:8080/diagnose?key=d73c47c0-3c15-11e6-8c40-0242ac110001

Change-Id: Ieba6da4d2a4333760022c68783c32dc2689a8a26
---
M src/kudu/integration-tests/master_failover-itest.cc
1 file changed, 45 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/3521/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieba6da4d2a4333760022c68783c32dc2689a8a26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to