Adar Dembo has posted comments on this change.

Change subject: locks: add new read-write mutex
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3496/5/src/kudu/util/mutex.cc
File src/kudu/util/mutex.cc:

Line 87:   DCHECK_EQ(0, rv) << ". " << strerror(rv)
> I still don't really get what this is about.  Is the point just to avoid an
The problem is that it's not lint that's complaining about the unused variable; 
it's the compiler. Doing it this way seemed about as intrusive as using 
__attribute__ ((unused)) to me, so I went with the approach with less cognitive 
load (i.e. no new concepts).


-- 
To view, visit http://gerrit.cloudera.org:8080/3496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to