Adar Dembo has submitted this change and it was merged.

Change subject: locks: switch from boost::shared_mutex to new read-write mutex
......................................................................


locks: switch from boost::shared_mutex to new read-write mutex

Here are the changed mutexes:
1. log allocation state lock. Only taken before and after segment
   preallocation, which doesn't seem like a hot path.
2. webserver lock: Protects the handler map and footer. Almost always
   uncontended, and the web UI is not a hot path anyway.
3. tablet status listener lock: Protects the last status seen. Almost always
   uncontended; it's acquired often by the remote bootstrap client, but the
   only other acquirer would be the web UI or ListTablets() RPC.
4. scanner manager stripe lock: Protects a particular stripe's scanner map.
   This one is a hot path with contention, I think.

Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
Reviewed-on: http://gerrit.cloudera.org:8080/3499
Tested-by: Adar Dembo <a...@cloudera.com>
Reviewed-by: Dan Burkert <d...@cloudera.com>
Reviewed-by: Todd Lipcon <t...@apache.org>
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_bootstrap.h
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/scanners.h
8 files changed, 24 insertions(+), 27 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, but someone else must approve
  Adar Dembo: Verified
  Todd Lipcon: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to