Dan Burkert has posted comments on this change. Change subject: Implement SchemaRelationProvider ......................................................................
Patch Set 1: (1 comment) LGTM except for the style nit. http://gerrit.cloudera.org:8080/#/c/3529/1/java/kudu-spark/src/main/scala/org/kududb/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/kududb/spark/kudu/DefaultSource.scala: Line 140: override def schema: StructType = { I think the body of this would be clearer as: userSchema match { case Some(x) => StructType(x.fields.map(uf => table.getSchema.getColumn(uf.name)) .map(kuduColumnToSparkField)) case None => StructType(table.getSchema.getColumns.asScala.map(kuduColumnToSparkField).toArray) } -- To view, visit http://gerrit.cloudera.org:8080/3529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4194d7ec139f0f9e3c1d508e8aca860484839d56 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andy Grove <andygrov...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
