Todd Lipcon has posted comments on this change.

Change subject: Show software vers to tablets in master web server
......................................................................


Patch Set 2:

(2 comments)

please also add a new assertion in registration-test.cc to check that the 
version info string shows up in the tablet servers page

http://gerrit.cloudera.org:8080/#/c/3535/2//COMMIT_MSG
Commit Message:

PS2, Line 7: software vers to tablets
"software version of tablet servers"

also, include the JIRA number here, like 'KUDU-12345: include software version 
of tablet servers in master web server'


http://gerrit.cloudera.org:8080/#/c/3535/2/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:

Line 279:   reg->set_software_version(vers);
I think better to just combine the above two lines into one rather than adding 
the local variable


-- 
To view, visit http://gerrit.cloudera.org:8080/3535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b32608c9e12a47f422b5047591d4098d187478
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to