Adar Dembo has posted comments on this change.

Change subject: Show software vers to tablets in master web server
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3535/2/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:

Line 277:   // Also register the Kudu version in the initial heartbeat
Nit: the comment isn't quite correct in that registration information may be 
sent outside of the initial heartbeat too. Given the simplicity of the new code 
to follow, I'd just remove the comment altogether.


-- 
To view, visit http://gerrit.cloudera.org:8080/3535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b32608c9e12a47f422b5047591d4098d187478
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to