Andrew Wong has posted comments on this change.

Change subject: Show software version of tablet servers
......................................................................


Patch Set 3:

(3 comments)

> (2 comments)
 > 
 > please also add a new assertion in registration-test.cc to check
 > that the version info string shows up in the tablet servers page

Working on that now

http://gerrit.cloudera.org:8080/#/c/3535/2//COMMIT_MSG
Commit Message:

PS2, Line 7: software version of tabl
> "software version of tablet servers"
Done


http://gerrit.cloudera.org:8080/#/c/3535/2/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:

Line 277:   reg->set_software_version(VersionInfo::GetShortVersionString());
> Nit: the comment isn't quite correct in that registration information may b
Done


Line 279:   return Status::OK();
> I think better to just combine the above two lines into one rather than add
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b32608c9e12a47f422b5047591d4098d187478
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to